Expose DeviceCommissioner::ComputePASEVerifier to Obj-C.
#22112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #22112: Size comparison from fee403e to bbb9322 Increases (4 builds for bl602, psoc6, telink)
Decreases (2 builds for esp32, psoc6)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
emargolis
approved these changes
Aug 23, 2022
mburshteyn1
force-pushed
the
darwin_compute_pase_verifier
branch
from
bbb9322 to
9ec86f2
Compare
mburshteyn1
force-pushed
the
darwin_compute_pase_verifier
branch
from
9ec86f2 to
eded3be
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov and
LuDuda
pullapprove
bot
requested review from
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #22112: Size comparison from 82d974b to a06578d Increases (2 builds for cc13x2_26x2, psoc6)
Decreases (4 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
mspang
approved these changes
Aug 25, 2022
woody-apple
approved these changes
Aug 25, 2022
Comment on lines
+674
to
+675
| if (![self isRunning]) { | ||
| [self checkForError:errorCode logMsg:kErrorNotRunning error:nil]; |
There was a problem hiding this comment.
Please use checkIsRunning.
|
|
||
| __block NSData * result; | ||
| __block chip::Spake2pVerifier paseVerifier; | ||
| __block chip::ByteSpan saltByteSpan = chip::ByteSpan(static_cast<const uint8_t *>(salt.bytes), salt.length); |
There was a problem hiding this comment.
Please use AsByteSpan().
| dispatch_sync(_chipWorkQueue, ^{ | ||
| if ([self isRunning]) { | ||
| errorCode = self.cppCommissioner->ComputePASEVerifier(iterations, setupPincode, saltByteSpan, paseVerifier); | ||
| MTR_LOG_ERROR("ComputePaseVerifier: %s", chip::ErrorStr(errorCode)); |
There was a problem hiding this comment.
And if this fails... now what? We return garbage?
| memcpy(serializedVerifier, paseVerifier.mW0, chip::kSpake2p_WS_Length); | ||
| memcpy(&serializedVerifier[sizeof(paseVerifier.mW0)], paseVerifier.mL, sizeof(paseVerifier.mL)); | ||
|
|
||
| result = [NSData dataWithBytes:serializedVerifier length:sizeof(serializedVerifier)]; |
There was a problem hiding this comment.
Please use AsData().
|
Also, why is this API on MTRDeviceController instances at all? It does not use any instance state, either in practice or conceptually. In the SDK API it's an instance API on DeviceCommissioner, but that's also an odd API choice and we should not be propagating it into the Darwin framework. |
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…hip#22112) * Expose `DeviceCommissioner::ComputePASEVerifier` to Obj-C. * Restyled by whitespace * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DeviceCommissioner::ComputePASEVerifierto Obj-C.Change overview
Added function
computePaseVerifier:iterations:salt:toMTRDeviceControllerto exposeDeviceCommissioner ::ComputePASEVerifierto Obj-C.